[AKS] az aks nodepool update: Add GPU driver install options install and none for --gpu-driver parameter#9472
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks nodepool update | cmd aks nodepool update added parameter gpu_driver |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
Hi @lilypan26, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR adds the --gpu-driver parameter to the az aks nodepool update command to control GPU driver installation on node pools. The parameter accepts values "Install" or "None" to either install or skip GPU driver installation.
Key Changes:
- Added
gpu_driverparameter configuration toaz aks nodepool updatecommand in _params.py - Updated HISTORY.rst to document the new feature in version 19.0.0b19
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/_params.py | Adds gpu_driver parameter configuration to the aks nodepool update argument context using the existing gpu_driver_install_modes enum |
| src/aks-preview/HISTORY.rst | Documents the addition of --gpu-driver option to az aks nodepool update command in version 19.0.0b19 |
| ) | ||
| c.argument( | ||
| "gpu_driver", | ||
| arg_type=get_enum_type(gpu_driver_install_modes) |
There was a problem hiding this comment.
The gpu_driver parameter is missing documentation. Add a help parameter to provide guidance to users, similar to line 1978. Based on the help text in _help.py line 2162, consider adding: help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'."
| arg_type=get_enum_type(gpu_driver_install_modes) | |
| arg_type=get_enum_type(gpu_driver_install_modes), | |
| help="Whether to install driver for GPU node pool. Possible values are 'Install' or 'None'. Default is 'Install'." |
|
please fix failed CI checks GH Azdev Linter / azdev-linter (pull_request_target)
|
FumingZhang
left a comment
FumingZhang
left a comment
There was a problem hiding this comment.
As mentioned in this comment, you also need to update the backend AKSAgentPoolUpdateDecorator
lilypan26
force-pushed
the
lily/update-gpu-driver
branch
from
5740655 to
7973fe2
Compare
github-actions
bot
added
the
release-version-block
github-actions
bot
removed
the
release-version-block
|
[Release] Update index.json for extension [ aks-preview-19.0.0b18 ] : https://dev.azure.com/msazure/One/_build/results?buildId=147195849&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --gpu-driver noneGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.